Fix blob function usage #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the PR [1] with the switch from 'rune-0.12' to 'rune-0.13' the 'blob' function changed it's return type from 'rune::runtime::Bytes' to the 'Vec<u8>'. Such a change required also an update to the input values parser to expect one more input type match to the 'ColumnType::Blob'. So, add the missing parsing element to make the 'blob' function work again as it was before. It will allow to avoid manual wrapping into the 'rune::runtime::Bytes' type in rune scripts. [1] pkolaczk#96
vponomaryov
force-pushed
the
fix-blob-fn
branch
from
ac6143f to
6c771a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PR (#96) with the switch from
rune-0.12torune-0.13the
blobfunction changed it's return type fromrune::runtime::Bytesto theVec<u8>.Such a change required also an update to the input values parser
to expect one more input type match to the
ColumnType::Blob.So, add the missing parsing element to make the
blobfunction work again as it was before.It will allow to avoid manual wrapping into the
rune::runtime::Bytestype in rune scripts.