pkp/pkp-lib#10511 fix and cleanup invalid series navigation menu items

[kaitlinnewson]

No description provided.

[jonasraoni]

Hi @kaitlinnewson! I just requested one update.

[jonasraoni]

Ah, I've spotted another problem...

The offending menu item can be the parent of other menu items, so if you remove it, the dependent items will be gone as well... In fact not, because a foreign key was forgotten (I'll create/update another issue to cover it), anyway, it needs to be addressed 🙃

So again, we have two options:

• Removing such item should cause its children to take its place on the tree.
• We setup the path with null and "convert" such items to a placeholder (it doesn't exist, so the closest to it would be a URL item pointing perhaps to ./).

[jonasraoni]

FYI the current behavior is to hide everything which is under an orphan menu item, which I don't think it's ideal 🤔

[kaitlinnewson]

@jonasraoni PR has been updated and ready for another look. I noticed there is only one level of nesting in the menus, so I opted to set the parent to null instead, which keeps it assigned in the navigation menu. Alternatively we could delete it from navigation_menu_item_assignments and then it would still exist but just not be assigned to the menu.