Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reviewer suggestion (#4787) E2E tests to add #10993

Open
10 tasks
touhidurabir opened this issue Feb 27, 2025 · 0 comments
Open
10 tasks

Reviewer suggestion (#4787) E2E tests to add #10993

touhidurabir opened this issue Feb 27, 2025 · 0 comments
Assignees
@touhidurabir
Labels
Housekeeping:2:Urgent Any dependency management or refactor that must be done soon to fix or avoid a significant problem.
Milestone
3.5 Internal

Comments

@touhidurabir
Copy link
Member

touhidurabir commented Feb 27, 2025 •
edited
Loading

Description:
With the merge of #4787, now it's possible to add reviewer suggestion for a submission in OJS/OMP . As this feature add a lot of cases and introduce several new options in workflow, need to add comprehensive cypress tests for this which include

  • Enable/Disable reviewer suggestion in settings and impact on submission wizard
  • Add/Edit/Delete reviewer suggestions along with validation
  • Enable/Disable reviewer suggestion in settings which impact the visibility to suggested reviewers in submission and review (only external review stage for OMP) stage
  • Confirm/Approve a suggested reviewer that does not exists from Add Reviewer modal and right side panel
  • Confirm/Approve a suggested reviewer that does exists as user with reviewer role from Add Reviewer modal and right side panel
  • Confirm/Approve a suggested reviewer that does exists as user but without reviewer role from Add Reviewer modal and right side panel
  • Add a reviewer from Add Reviewer modal which match a suggested reviewer and it's impact .
  • Create a new reviewer from Add Reviewer modal which match a suggested reviewer and it's impact .
  • Enroll existing user that match reviewer suggestion
  • Add existing reviewer from pre existing reviewer list that match particular suggested reviewer

What application are you using?
OJS, OMP or OPS version main (upcoming 3.5)

PRs

Stable-3.5.0

pkp-lib --> #11054
ui-library --> pkp/ui-library#554
ojs --> pkp/ojs#4726
omp --> pkp/omp#1885

main

pkp-lib --> #11056
ui-library --> pkp/ui-library#555
ojs --> pkp/ojs#4727
omp --> pkp/omp#1890
@touhidurabir touhidurabir self-assigned this Feb 27, 2025
@touhidurabir touhidurabir added this to the 3.5 Internal milestone Feb 27, 2025
@touhidurabir touhidurabir added the Housekeeping:2:Urgent Any dependency management or refactor that must be done soon to fix or avoid a significant problem. label Feb 27, 2025
touhidurabir added a commit to touhidurabir/ui-library that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
5d34242
touhidurabir added a commit to touhidurabir/ui-library that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
362a3d6
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Mar 10, 2025
@touhidurabir
pkp#10993 Reviewer Suggestion E2E test
5fbde91
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Mar 10, 2025
@touhidurabir
pkp#10993 Reviewer Suggestion E2E test
bc3b507
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
cbcc4cd
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_stable_3_5_0##
adc0442
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
a5f3f06
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_stable_3_5_0##
7bc6684
This was referenced Mar 10, 2025
Open
Open
Open
@touhidurabir touhidurabir linked a pull request Mar 10, 2025 that will close this issue
pkp/pkp-lib#10993 Reviewer Suggestion E2E test pkp/ui-library#554
Open
@touhidurabir touhidurabir removed a link to a pull request Mar 10, 2025
pkp/pkp-lib#10993 Reviewer Suggestion E2E test pkp/ui-library#554
Open
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 updated data suit test data
e53e7e6
touhidurabir added a commit to touhidurabir/omp that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
a51a6d6
touhidurabir added a commit to touhidurabir/omp that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_stable_3_5_0##
ed56ccd
@touhidurabir touhidurabir mentioned this issue Mar 10, 2025
Open
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Mar 10, 2025
@touhidurabir
pkp#10993 Reviewer Suggestion E2E test
08a0822
touhidurabir added a commit to touhidurabir/ui-library that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
a5d7e90
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
e8e946f
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
d7d599f
This was referenced Mar 10, 2025
Open
Open
Open
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 moved reviewer suggestion enable to before action
e63efdc
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Mar 10, 2025
@touhidurabir
pkp#10993 Reviewer Suggestion E2E test
152ab12
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_stable_3_5_0##
663eae7
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 added cypress uncaught:exception handler for intent…
76c2c03 
…ional api validation error
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 removed api validation failure tests
df81bd7
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 added several wait and waitJQuery to run tests smoo…
bf7b0a5 
…thly
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 removed waitJquery calls
a9e2f74
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
0a6d7d9 
pkp/pkp-lib#10993 updated data suit test data

pkp/pkp-lib#10993 moved reviewer suggestion enable to before action

pkp/pkp-lib#10993 added cypress uncaught:exception handler for intentional api validation error

pkp/pkp-lib#10993 removed api validation failure tests

pkp/pkp-lib#10993 added several wait and waitJQuery to run tests smoothly

pkp/pkp-lib#10993 removed waitJquery calls
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_stable_3_5_0##
03c21b9 
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_stable_3_5_0##
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Mar 11, 2025
@touhidurabir
pkp#10993 Reviewer Suggestion E2E test
f8b221b
touhidurabir added a commit to touhidurabir/omp that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 update test conditions
f79edf4
touhidurabir added a commit to touhidurabir/omp that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_stable_3_5_0##
9e30678
touhidurabir added a commit to touhidurabir/omp that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
185b66a
touhidurabir added a commit to touhidurabir/omp that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_stable_3_5_0##
5e3b978
touhidurabir added a commit to touhidurabir/omp that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 update test conditions
9510c1d
touhidurabir added a commit to touhidurabir/omp that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
ff67f8c 
pkp/pkp-lib#10993 update test conditions
touhidurabir added a commit to touhidurabir/omp that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_stable_3_5_0##
2f0dc50
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Mar 11, 2025
@touhidurabir
pkp#10993 Reviewer Suggestion E2E test
dfd0cfb
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 test update
64d9a10
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
e09555f
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
d9715f5
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
dfb727a
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 test update
de5b80c
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
f26847a 
pkp/pkp-lib#10993 test update
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
3efe5aa
touhidurabir added a commit to touhidurabir/omp that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer suggestion E2E test
63f1364
touhidurabir added a commit to touhidurabir/omp that referenced this issue Mar 11, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
5a3a9dd
@touhidurabir touhidurabir mentioned this issue Mar 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@touhidurabir touhidurabir

Labels
Housekeeping:2:Urgent Any dependency management or refactor that must be done soon to fix or avoid a significant problem.
Projects
None yet
Milestone
3.5 Internal
Development

No branches or pull requests
1 participant
@touhidurabir