-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add HasCamelCasing trait to UserGroupStage, UserUserGroup, and InvitationModel models #10250
Conversation
09d9dbb
to
202fa9f
Compare
Ready for review @asmecher |
Thanks, @taslangraham! @defstat, would you mind reviewing this? |
@taslangraham thanks, this trait saves so much code and it is super helpful. Can you add the necessary PRs on OJS, OMP, OPS so that the tests run on the pkp-lib PR? |
d2723e7
to
23c96fa
Compare
If you need any help with the tests I will be happy to help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @taslangraham. Just check one test that has already failed on OMP. It could be a test glitch and could be resolved if you rerun it. But check if this is the case. Other than that I have no comments on the code
23c96fa
to
12f5263
Compare
…d InvitationModel
12f5263
to
428f962
Compare
@defstat all tests are now passing. |
Perfect, I have no other comments |
@defstat I don't have write access. If you do, could you please merge this? |
@taslangraham everything merged! Thanks. |
For #10234