pkp/pkp-lib#10571 limit email template access by user groups #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
7 times, most recently
from
93b5d1b
to
ea460df
Compare
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
from
ea460df
to
cf3b437
Compare
taslangraham
changed the title
ewhanson
requested changes
Nov 21, 2024
| @@ -408,6 +408,13 @@ export default { | |||
| }); | |||
| } | |||
|
|
|||
| // Remove user group fields if current mailable does not support specifying user group access | |||
| if (!this.currentMailable.canAssignUserGroupToTemplates) { | |||
There was a problem hiding this comment.
I think more of this can be done on the PHP side of things in the EmailTemplateForm. This kind of goes for all of the UI side of things, especially at this stage. We can go over some of this in our next one-on-one if that's helpful.
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
5 times, most recently
from
50b1752
to
375426e
Compare
…email templates within a mailable
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
from
375426e
to
34d9dda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For pkp/pkp-lib#10571