Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix. Partial recv in debug loop #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moteus
Copy link
Contributor

@moteus moteus commented Jan 8, 2022

Is there any guidlines for code style for this module?
E.g. is it safe to decompose debug_loop function?
Righ now I working on addition a new protocol and it will be much easily to do this if
split protocol from implementation.

@pkulchenko
Copy link
Owner

Interesting; I don't think there are any strict guidelines, but it may be worthwhile to implement some basic protocol elements you want to add first (with the mobdebug changes you'd need) and then review/discuss those.

@moteus
Copy link
Contributor Author

moteus commented Jan 8, 2022

I working on VSCode extension for ModDebug library.
My main concerns is it safe to move lines like capture_vars(stack-1, coro_debugee) to a separate function.

@pkulchenko
Copy link
Owner

Yes, it may be possible to move it, but I suspect that stack-1 index will have to be adjusted accordingly for the depth added by the additional function calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants