Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace our check dialect with upstreaming to RunnerUtils.cpp #554

Open
rengolin opened this issue May 19, 2023 · 0 comments
Open

Replace our check dialect with upstreaming to RunnerUtils.cpp #554

rengolin opened this issue May 19, 2023 · 0 comments

Comments

@rengolin
Copy link
Contributor

RunnerUtils.cpp already has verifiers that we can use for equality.

Instead of adding a new dialect, I think we just need a local utility builder that can lower to the right runtime calls (and declare them in IR). But to get the almost_equals logic, we'll need to upstream that part. We need this for existing types and bf16 too (both verify and almost_equals).

It should be trivial to just follow the existing pattern and add this functionality upstream, then change out test to use the new style, removing the check dialect from the picture.

While we're at it, we could also add a printMemrefBF16 variant...

@KavithaTipturMadhu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant