Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace our vector print in tpp-run with upstream printMemrefF32 #555

Open
rengolin opened this issue May 19, 2023 · 1 comment
Open

Replace our vector print in tpp-run with upstream printMemrefF32 #555

rengolin opened this issue May 19, 2023 · 1 comment

Comments

@rengolin
Copy link
Contributor

Right now there's only f32 variant of print, not bf16 so we had to use the vector lowering.

But if we upstream a printMemrefBF16 (see #554), then we can just use that and not have to worry about the rank and dims of the returned tensors (see #176).

@adam-smnk @KavithaTipturMadhu
@rengolin rengolin mentioned this issue Aug 14, 2023
Merged
@rengolin rengolin mentioned this issue Sep 11, 2023
Merged
@rengolin
Copy link
Contributor Author

Interesting development: llvm/llvm-project#68695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rengolin