Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntelAMX TileConfig Hoisting should be anchored on IntelAMXTileConfigDispatchOp #896

Open
alheinecke opened this issue Mar 1, 2024 · 0 comments

Comments

@alheinecke
Copy link
Contributor

The Intel AMX TileConfig Hoisting uses today the AllocaOp for the tileconfig state as anchor op and then attempts to move IntelAMXTileConfigDispatchOp around based on a test if the AllocOp is used by IntelAMXTileConfigDispatchOp.

https://github.com/plaidml/tpp-mlir/blob/main/lib/TPP/Transforms/IntelAMXTileConfigHoisting.cpp#L31

However, we are now attempting to rewrite every alloca and error out if the alloca is not used by IntelAMXTileConfigDispatchOp.

It would a cleaner design if we would rewrite based on IntelAMXTileConfigDispatchOp. However, I see also challenges here, as we have 2 Ops around a BRGEMM, hence the alloca-"Trick" in the current pass made it simple to rewrite.

Let's discuss suggestions on how to make this cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant