Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile configuration addition pass #890

Merged
merged 10 commits into from
Mar 1, 2024

Conversation

KavithaTipturMadhu
Copy link
Contributor

@KavithaTipturMadhu KavithaTipturMadhu commented Feb 26, 2024

Test cases to be added, draft PR in progress. Runtime and code changes are done, licm hoisting is incomplete, working on it.

Copy link
Contributor

@rengolin rengolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You really need tests.

lib/TPP/Transforms/TileConfig.cpp Outdated Show resolved Hide resolved
lib/TPP/Transforms/TileConfig.cpp Outdated Show resolved Hide resolved
lib/TPP/Transforms/TileConfig.cpp Outdated Show resolved Hide resolved
lib/TPP/Transforms/TileConfig.cpp Outdated Show resolved Hide resolved
include/TPP/Dialect/Xsmm/XsmmOps.td Outdated Show resolved Hide resolved
lib/TPP/Transforms/TileConfig.cpp Outdated Show resolved Hide resolved
lib/TPP/Transforms/TileConfig.cpp Outdated Show resolved Hide resolved
@alheinecke
Copy link
Contributor

@KavithaTipturMadhu On a second thought on the sames and what might have created also confusion on @adam-smnk side: l suggest renaming TileConfig to IntelAMXTileConfig in both pass names, etc. Then it;s clear this has nothing to do with tiling in general but with Intel AMX in particular.

@rengolin rengolin added the benchmark Triggers benchmark jobs label Feb 27, 2024
@KavithaTipturMadhu KavithaTipturMadhu marked this pull request as ready for review March 1, 2024 09:19
@rengolin rengolin added benchmark Triggers benchmark jobs and removed benchmark Triggers benchmark jobs labels Mar 1, 2024
@rengolin rengolin merged commit 3f7d734 into plaidml:main Mar 1, 2024
18 checks passed
nhasabni pushed a commit that referenced this pull request Mar 14, 2024
Test cases to be added, draft PR in progress. Runtime and code changes
are done, licm hoisting is incomplete, working on it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Triggers benchmark jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants