Loop tiling, shuffle and expansion passes #922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't done a detailed review, but it seems the old 2d parallelization is disabled/removed from tpp-run. I suggest for now we keep the old one functional in the default pass and make the new one available through a different knob. Then we can compare both and retire the old one, when the new one completely covers the old usecases. |
KavithaTipturMadhu
force-pushed
the
looptiling
branch
10 times, most recently
from
7a1aa5d to
e6c1086
Compare
|
I am working on unit tests for the passes as well as MLP integration tests, in the meantime we can start the review. |
KavithaTipturMadhu
force-pushed
the
looptiling
branch
4 times, most recently
from
799e90f to
16cea04
Compare
KavithaTipturMadhu
force-pushed
the
looptiling
branch
4 times, most recently
from
ca7692b to
c1ce01e
Compare
KavithaTipturMadhu
added
benchmark
KavithaTipturMadhu
force-pushed
the
looptiling
branch
from
c1ce01e to
73d293f
Compare
… the shape of the tensor
KavithaTipturMadhu
force-pushed
the
looptiling
branch
from
86d94e0 to
9a0ab09
Compare
KavithaTipturMadhu
added
benchmark
|
Closing this PR since we're moving this pass to vector dialect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.