mlir-gen - use empty as outs for named eltwise operations #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts mlir-gen named ops generation to use tensor.empty as output destination. For linalg named eltwise operations, outs value is write only. Using empty as a destination placeholder instead of zero initialized value improves bufferization and overall IR quality.
|
This also aligns our named benchmarks with more realistic IR like one generated by OV. |
Any change in benchmark numbers? |
Not as of right now that is: no changes in the older benchmarks and no impact on the named case. |
rengolin
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts mlir-gen named ops generation to use tensor.empty as output destination.
For linalg named eltwise operations, outs value is write only. Using empty as a destination placeholder instead of zero initialized value improves bufferization and overall IR quality.