Support inplace generic in compare-select to max rewrite #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PyTorch benchmarks will take a temporary hit in performance. This will be fixed by #955. |
Simplifies conversion to only change generic's body operation without affecting operation operands. This prevents crashes when generic has inplace format. Originally the pass would also implicitly rewrite generic operation to be in place by replacing output with the input. This is removed to improve robustness and better separate concerns. Inplace rewrite will be handled by a separate pass later on.
adam-smnk
force-pushed
the
compare-to-max-inplace-fix
branch
from
8e72b66 to
1ea47c4
Compare
adam-smnk
added
benchmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies conversion to only change generic's body operation without affecting operation operands. This prevents crashes when generic has inplace format.
Originally the pass would also implicitly rewrite generic operation to be in place by replacing output with the input. This is removed to improve robustness and better separate concerns. Inplace rewrite will be handled by a separate pass later on.