Pack matmuls with small dimensions #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends pack matmul control function to automatically adapt blocking factors for small dimensions.
The new behavior is that the defined or default packing sizes define the upper bound on the tile size. Dimensions smaller than their block factors are still packed using their whole size.
This change allows processing matmuls on tall-and-skinny matrices and partially decouples the decision of what and how to pack from the mechanism itself. For simplicity, any small matmul is be packed now.
Long-term, packing driver should be augmented with a separate cost functions that governs operation selection, need for padding, smartly adjusts blocking factors etc.