-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vector-to-kernel pipeline bundle #987
Conversation
…t because of skipoperations. This commit is just to check CI and will be reverted back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good
@rengolin Responded to your comments. Please have a look. |
@rengolin Removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
The PR
Vector-to-kernel pipeline bundle
does the following:Bundles the four passes: brgemm tiling (Linalgtiling #974), vectorization (Linalg->Vector dialect pass and pipeline changes #958), hoisting vector transfers (Hoist vector transfers outside reduction and k loop #977), and vector to fma (Lower vector.contract to chain of vector.fma for matrix multiply. #978) together for the
vector-to-kernel
pipeline.New
json
files are added to benchmark folder for benchmarking thevector-to-kernel
pipeline.a)
/base/vector.json
: tests the base sequential version for mlp/gemm fp-32b)
/omp/mlp-fp32-vector.json
: tests theomp
version for mlp/gemm-fp32c)
/omp/torch-dynamo-vector-to-kernel.json
: tests theomp
vesion for torch mlp/gemm-fp32.Updating the
brgemm
default tile size tolhsTile:4,32
andrhsTile:32,1
, as this size emits the bettergflops
.