Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support controlled mysqld version upgrade with rollback #446

Closed
maxenglander opened this issue Jul 19, 2023 · 1 comment · Fixed by #524
Closed

Feature request: support controlled mysqld version upgrade with rollback #446

maxenglander opened this issue Jul 19, 2023 · 1 comment · Fixed by #524
Assignees

Comments

@maxenglander
Copy link
Contributor

Currently the way to upgrade from mysql 57 to 80 in the operator is to change mysqld image version. This causes operator to do a rolling upgrade of tablets. There's a lot that could go wrong here, and it would be nice if there were an option to do a controlled migration from 57 to 80.

One way this could work in theory is to create a new keyspace configured with mysql 80, and do a MoveTables from the 57 keyspace to the 80. This would allow carefully testing and validating that the upgrade succeeded before doing SwitchTraffic, and in theory would allow switching back to 57 if issues were discovered in 80 after SwitchTraffic (modulo reverse replication issues).

Assuming this idea is sound, what would be needed is to patch the operator to allow specifying mysqld image per keyspace. Currently this is not allowed, and the docs say:

vitess-operator/docs/api.md

Lines 5280 to 5283 in 5bf4279

<p>Images are not customizable by users at the keyspace level because version
skew across the cluster is discouraged except during rolling updates,
in which case this field is automatically managed by the VitessCluster
controller that owns this VitessKeyspace.</p>

@deepthi
Copy link
Collaborator

deepthi commented Jul 19, 2023

Currently the way to upgrade from mysql 57 to 80 in the operator is to change mysqld image version.

Just noting that this doesn't really work right now because the default collation in 8.0 does not exist in 5.7 and we are not setting an explicit collation in the mysql config file.

See #369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants