Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user-defined per-keyspace images feature is unusable #608

Closed
bluecrabs007 opened this issue Oct 8, 2024 · 1 comment
Closed

user-defined per-keyspace images feature is unusable #608

bluecrabs007 opened this issue Oct 8, 2024 · 1 comment
Assignees

Comments

@bluecrabs007
Copy link

The issue and the PR brings in the ability to create a new keyspace and override the mysqld container image.

This lets the user deploy a new keyspace with mysql8 in a vitesscluster deployed with mysql57 with the goal of letting the user MoveTables the data from the 57 keyspace to 80.

There are 2 issues with the current implementation and the version this feature was released in.

Issue 1:
This feature lets the user override the mysqld image only. This causes incompatibilities between the vttablet container and the mysqld container due to the version mismatch.
For example, the vttablet would be running the mysql57 version of xtrabackup which doesn't work with mysql80
it fails with error

xtrabackupengine.go:369] xtrabackup stderr: Error: MySQL 8.0 and Percona Server 8.0 are not supported by Percona Xtrabackup 2.4.x series. Please use Percona Xtrabackup 8.0.x for backups and restores.

Suggestion: A bug fix to enable support for user-definable per-keyspace images for vttablet, vtorc, myqsld exporter.

Issue 2:
This feature landed in vitess-operator v2.12.0 which corresponds to vitess v19, which drops support for mysql57.
Suggestion: Backport this feature to v2.11.x so that users can migrate off mysql 57 from the last vitess version that supports mysql57

@bluecrabs007 bluecrabs007 changed the title support for user-defined per-keyspace images is unusable user-defined per-keyspace images feature is unusable Oct 8, 2024
@frouioui frouioui self-assigned this Oct 8, 2024
@frouioui
Copy link
Member

frouioui commented Oct 8, 2024

Hey @bluecrabs007, thanks for opening this. This is a reasonable thing to do in vitess-operator.

I have opened #610, which will solve the Issue 1. Which must be backported all the way to release-2.11.

And I have #609 to backport the original fix made in v2.12. This should solve Issue 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants