[release-2.11] Add support for user-defined per-keyspace images #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Englander <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Max Englander <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
…nts about version skew Signed-off-by: Max Englander <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
maxenglander
approved these changes
Oct 8, 2024
mattlord
approved these changes
Oct 8, 2024
| Mysql80Compatible string `json:"mysql80Compatible,omitempty"` | ||
| } | ||
|
|
||
| // TODO: Remove this once everything is migrated to MysqldImageNew. |
There was a problem hiding this comment.
This isn't right, is it? I thought that the migration was going to happen in the other direction and New will be removed?
There was a problem hiding this comment.
We will be removing MysqldImage in v2.15 and renaming MysqldImageNew to MysqldImage at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #524 into
release-2.11.The motivation for this backport stems from #608, as explained by @bluecrabs007, the goal of the original PR is to support two versions of MySQL in the cluster instead of using the same one everywhere, this is very useful as we were deprecating MySQL 5.7. However, we deprecated MySQL 5.7 in v18.0.0 (equivalent of v2.11 in vtop) and removed it entirely from the code base in v19.0.0 (equivalent v2.12 in vtop).
We want to backport this to
v2.11so users can use the feature, and thus migrate more easily, on a version of Vitess where MySQL 5.7 is still supported.This PR is part of #608. It fixes the
Issue 2described.