Pass extra env to all vttablet containers #518
Conversation
This change propogates the vttablet extraEnv to the mysqld_exporter. This allows for the mysqld_exporter to be configured with the same environment variables as the vttablet and mysqld containers. This is useful for configuring an AWS IAM-based service account, which automatically injects additional AWS_* environment variables into the pod. Without this, the operator continuously restarts the pod due to trying to remove the AWS_* environment variables from the mysqld_exporter container. Signed-off-by: Jared Hampson <[email protected]>
Signed-off-by: Jared Hampson <[email protected]>
jhampson-dbre
force-pushed
the
pass-extraEnv-to-all-vttablet-containers
branch
from
a809bbf to
f786c62
Compare
There was a problem hiding this comment.
Thank you for the contribution, @jhampson-dbre ! This seems like a safe and sensible change to me.
I wonder if this is also related to: #514
Yes, this seems like we need some way to allow "extraVars" diffs to be ignored and not assume the pod needs to be recreated I suppose. This likely is the same thing on #514, but it seems a temporary fix, and any new containers in the pod in the future could hit this again. |
|
I believe setting pull secret on the service account causes the pod's spec.imagePullSecrets to be defined automatically. So similar issue where some k8s magic causes some implicit changes to the pod, but in this case I think the option for defining the pull secret in the VitessCluster spec should cause the operator expected state to match. In our case with env vars, they aren't passed through to all the containers in the pod so the spec will never match. |
|
Thank you for this contribution, it looks great to me! |
This allows for the mysqld-exporter to be configured with the same
environment variables as the vttablet and mysqld containers. This
is useful for configuring an AWS IAM-based service account, which
automatically injects additional AWS_* environment variables into
the pod. Without this, the operator continuously restarts the vttablet
pod due to trying to remove the AWS_* environment variables from
the mysqld-exporter container.
Related to #383