Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vitess-operator][helm-chart] update #668

Closed
wants to merge 24 commits into from

Conversation

luismacosta
Copy link

@luismacosta luismacosta commented Mar 2, 2025

Purpose:

  • [vitess-operator][helm-chart] update

Changes:

  • create templates folder + .helmignore + _helpers.tpl + values.yaml + Chart.yaml + README.md
  • update operator.yaml + service_account.yaml

Tests:

cd deploy
helm template . --name-template vitess-operator -n vitess-operator -f values.yaml > test.yaml --debug

@frouioui @mattlord can you please review this PR? Thanks

frouioui and others added 7 commits March 2, 2025 21:14
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: luis.costa <[email protected]>
This reverts commit 965b59f.

Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: luis.costa <[email protected]>
mattlord and others added 14 commits March 2, 2025 21:32
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand the purpose of this Pull Request and what its use would be.

@deepthi
Copy link
Collaborator

deepthi commented Mar 3, 2025

As @frouioui pointed out in slack, we do not currently provide a helm chart for deploying vitess-operator, nor do we intend to do so.
Beyond that, my main objection to this PR is that it replaces operator.yaml that works directly with vitess-operator with a template that requires people to use helm.
You are welcome to publish a helm chart template for vitess-operator in some other public repo.

@deepthi deepthi closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants