Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desactivate named servers #180

Merged
merged 4 commits into from
Jul 9, 2020
Merged

Desactivate named servers #180

merged 4 commits into from
Jul 9, 2020

Conversation

pierrepo
Copy link
Contributor

@pierrepo pierrepo commented Jul 8, 2020

  • Add / update the documentation

Fix #179

@pierrepo
Copy link
Contributor Author

pierrepo commented Jul 8, 2020

@jtpio I hope this PR is faithful to our discussion.

I tried to keep the documentation as concise as possible.

@pierrepo pierrepo requested a review from jtpio July 8, 2020 17:03
@jtpio
Copy link
Member

jtpio commented Jul 8, 2020

Looks good, thanks Pierre 👍

@pierrepo pierrepo requested a review from jtpio July 8, 2020 19:51
jtpio
jtpio approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@jtpio jtpio merged commit f0ba4d4 into master Jul 9, 2020
@jtpio jtpio deleted the set-default-without-named-servers branch July 9, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default Plasma config should not use Named servers
2 participants
@pierrepo @jtpio