Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sqlalchemy<2 #219

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Pin sqlalchemy<2 #219

merged 4 commits into from
Nov 14, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 14, 2023

Fixes #218.

Some transitive dependencies got newer major versions since the last time the repo was updated.

@jtpio jtpio changed the title Pin jupyterhub for now Set stricter pins for now Nov 14, 2023
@jtpio
Copy link
Member Author

jtpio commented Nov 14, 2023

Looks like the CI failure was related to the newer versions of sqlalchemy. Pinning on sqlalchemy<2 helps fix it.

Version 2.0 was released on January 19, 2023:

image

Ideally we should eventually drop the pin, maybe as prt of #216

@jtpio jtpio changed the title Set stricter pins for now Pin sqlalchemy<2 Nov 14, 2023
@jtpio jtpio marked this pull request as ready for review November 14, 2023 14:44
@jtpio
Copy link
Member Author

jtpio commented Nov 14, 2023

Getting this one in to help make progress with other PRs.

@jtpio jtpio merged commit 482b683 into plasmabio:master Nov 14, 2023
4 checks passed
@jtpio jtpio deleted the fix-ci branch November 14, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix running tests on CI
1 participant