Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and tweaks to state styles #402

Merged
merged 5 commits into from
Jul 28, 2020

Conversation

jhung
Copy link
Contributor

@jhung jhung commented Jul 7, 2020

Description

Steps to test

Search button:

  1. Test active state of the search button on the following:
    • Search button
    • Search form
    • Home Layout
  2. Search focus/active borders should appear consistent on both the input field and search button (see Search focus borders appear as different widths #363). Note: existing issues with box shadow rendering on Firefox may cause outer and inner borders to appear different widths. See In Firefox, active box-shadow causes rendering artifacts #360).
  3. The search button should invert when active See Inversed search button when active should invert #364 .

Menu button:

  1. Test the focus and active state on the following:
    • Menu button
    • Page layout (mobile)
    • Home layout (mobile)
  2. The focus border should be consistent in width and spacing across default and inverted styles. See Tweak menu button inverse focus and active state style #365 .

Radio group:

  1. Verify that the checked option in the Radio Group is Blue-500

Accordion:

  1. Test the active or focus state for the filter accordion button on the Archive layout.
  2. The top border of the next accordion button should not overlap with the active or focus styling (see Accordion displays inverse bottom border when control is active and focused #401)

@jhung jhung added bug Something isn't working enhancement New feature or request labels Jul 7, 2020
@jhung jhung added this to the 1.0.0-beta.4 milestone Jul 7, 2020
@jhung jhung self-assigned this Jul 7, 2020
@netlify
Copy link

netlify bot commented Jul 7, 2020

Deploy preview for pinecone ready!

Built with commit 28c870e

https://deploy-preview-402--pinecone.netlify.app

@jhung jhung requested a review from greatislander July 21, 2020 20:23
@jhung jhung marked this pull request as ready for review July 21, 2020 20:24
@jhung jhung marked this pull request as draft July 22, 2020 13:31
@jhung jhung marked this pull request as ready for review July 27, 2020 14:04
Copy link
Collaborator

@greatislander greatislander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@greatislander greatislander merged commit 1c49345 into platform-coop-toolkit:dev Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment