Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve non-provided optional variables to null #66

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DorianGrey11
Copy link
Contributor

When optional variables are not provided, they currently resolve to undefined rather than null. Since GraphQL only handles null values properly, this causes issues with expected handling of optional variables.

This PR modifies the behavior so that non-provided optional variables default to null instead of undefined. A new test case has been added to demonstrate this issue and verify the fix.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants