Re-allow output from "ssh-cert:load --refresh-only", now that quiet m…

…ode works (#1491) This partially reverts 29a9285
platformsh · Oct 15, 2024 · 32b225c · 32b225c
1 parent 0a45403
commit 32b225c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/Command/SshCert/SshCertLoadCommand.php b/src/Command/SshCert/SshCertLoadCommand.php
@@ -14,9 +14,7 @@ protected function configure()
     {
         $this
             ->setName('ssh-cert:load')
-            ->addOption('refresh-only', null, InputOption::VALUE_NONE,
-                'Only refresh the certificate, if necessary (do not write SSH config).'
-                . ' Unless verbose mode is used, this will not output messages.')
+            ->addOption('refresh-only', null, InputOption::VALUE_NONE, 'Only refresh the certificate, if necessary (do not write SSH config)')
             ->addOption('new', null, InputOption::VALUE_NONE, 'Force the certificate to be refreshed')
             ->addOption('new-key', null, InputOption::VALUE_NONE, 'Force a new key pair to be generated')
             ->setDescription('Generate an SSH certificate');
@@ -47,7 +45,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         $refresh = true;
         if (getenv(Ssh::SSH_NO_REFRESH_ENV_VAR)) {
-            if ($refreshOnly && !$this->stdErr->isVerbose()) {
+            if ($refreshOnly && $this->stdErr->isQuiet()) {
                 return 0;
             }
             $this->stdErr->writeln(sprintf('Not refreshing SSH certificate (<comment>%s</comment> variable is set)', Ssh::SSH_NO_REFRESH_ENV_VAR));
@@ -58,7 +56,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             && !$input->getOption('new')
             && !$input->getOption('new-key')
             && $certifier->isValid($sshCert)) {
-            if ($refreshOnly && !$this->stdErr->isVerbose()) {
+            if ($refreshOnly && $this->stdErr->isQuiet()) {
                 return 0;
             }
             $this->stdErr->writeln('A valid SSH certificate exists');
@@ -73,7 +71,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             if (!$sshConfig->checkRequiredVersion()) {
                 return 1;
             }
-            if ($refreshOnly && !$this->stdErr->isVerbose()) {
+            if ($refreshOnly && $this->stdErr->isQuiet()) {
                 $certifier->generateCertificate($sshCert, $input->getOption('new-key'));
                 return 0;
             }

diff --git a/src/Service/SshConfig.php b/src/Service/SshConfig.php
@@ -96,7 +96,7 @@ public function configureSessionSsh()
         $certificate = $this->certifier->getExistingCertificate();
         if ($certificate) {
             $executable = $this->config->get('application.executable');
-            $refreshCommand = sprintf('%s ssh-cert:load --refresh-only --yes', $executable);
+            $refreshCommand = sprintf('%s ssh-cert:load --refresh-only --yes --quiet', $executable);
 
             // On shells where it might work (POSIX compliant), skip refreshing
             // the certificate when the CLI_SSH_NO_REFRESH env var is set to 1.