Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to PHP8 versions of dependencies #1518

Closed
wants to merge 88 commits into from
Closed

Upgrade to PHP8 versions of dependencies #1518

wants to merge 88 commits into from

Conversation

pjcdawkins
Copy link
Collaborator

@pjcdawkins pjcdawkins commented Dec 16, 2024 •
edited
Loading

Based on #1506. Changes include:

  • Upgrade Guzzle from v5 to v7
  • Upgrade Symfony from v3 to v7
    • Convert commands to lazy-loaded
    • Autowire service dependencies
    • Move code from CommandBase and some other abstract classes to new services, same features (AutoLoginListener, CountryService, DrushAliasUpdater, HostFactory, InstallationInfo, Io, LegacyMigration, Login, ProjectSshInfo, ResourcesUtil, SelfInstallChecker, SelfUpdateChecker, SubCommandRunner, TunnelManager). Much of this but not all via Rector.
    • Use Symfony autocompletion (slight behavior change)
  • Upgrade Box from v3 to v4
  • Upgrade code to use PHP 8 features - type hints, etc.
  • Lint files with PHP-CS-Fixer with ruleset PSR12 for readability and PHP84Migration for compatibility
  • Lint files with PHPStan (level 7) for improved type safety

@pjcdawkins pjcdawkins force-pushed the upgrade-php-8-dependencies branch 2 times, most recently from e32457e to 863133f Compare December 16, 2024 14:46
@pjcdawkins pjcdawkins force-pushed the upgrade-php-8-dependencies branch 26 times, most recently from 5a6a8f6 to a129d36 Compare December 23, 2024 12:51
@pjcdawkins
Add Rector rule to remove unnecessary service variables
6cc8083
@pjcdawkins
Apply Rector rule to remove unnecessary service variables
f870add
@pjcdawkins
Remove straggling unnecessary service variables
df9e183
@pjcdawkins
Clarify Activity type
52909fb
@pjcdawkins
Clarify getCurrentDeployment type
d39d408
@pjcdawkins
Clarify table header and default columns types
141a30c
@pjcdawkins
Fix inactive environment handling in ssh command
ef33b63
@pjcdawkins
Refactor tunnels
807ad3d
@pjcdawkins
Fix some phpstan level 7 errors
1109fba
@pjcdawkins
Apply php-cs-fixer with default PSR12 ruleset
f5040c6
@pjcdawkins
Generate container when needed for linting
5c87b50
@pjcdawkins
Apply php-cs-fixer to other files
2444076
@pjcdawkins
Apply PER coding standard
85a9098
@pjcdawkins
Apply PHP84Migration ruleset
f569845
@pjcdawkins
Apply PHPStan to files other than src and tests
b2b3c68
@pjcdawkins
Fix typo in sync command description
d0eadb7
@pjcdawkins
Declare strict_types everywhere
e4496c1
@pjcdawkins
Fix assumption of true on no output from executing a command
d644ec8
@pjcdawkins
Various type fixes
fde6f54
@pjcdawkins
Type fixes in repo commands
143d510
@pjcdawkins
Type fix in variable:list command
67422f6
@pjcdawkins
Restore command examples in help
3d633f4
@pjcdawkins
Remove more unnecessary variables
efd8bbd
@pjcdawkins
Fix type issue in Git service
b2cf200
@pjcdawkins
Fix activity command bugs shown in Go tests
c96a639
@pjcdawkins
Fix creating a project variable without a selected env
461ac1f
@pjcdawkins pjcdawkins force-pushed the upgrade-php-8-dependencies branch from 080c969 to 461ac1f Compare December 27, 2024 09:28
@pjcdawkins
Copy link
Collaborator Author

This is now part of branch 5.x
https://github.com/platformsh/legacy-cli/tree/5.x

@pjcdawkins pjcdawkins closed this Dec 27, 2024
@pjcdawkins pjcdawkins deleted the upgrade-php-8-dependencies branch December 27, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pjcdawkins