Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: flatten ?filters=(...) to ?f=...&f=... #4810

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WIP: flatten ?filters=(...) to ?f=...&f=... #4810

wants to merge 4 commits into from
+95 −12

Conversation

apata
Copy link
Contributor

@apata apata commented Nov 12, 2024

Changes

Maybe solves issue with Plausible dashboard links not being rendered in Twitter DMs and other places?

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog
  • This PR does not make a user-facing change

Documentation

  • Docs have been updated
  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
  • This PR does not change the UI

@apata apata added the preview label Nov 12, 2024
@github-actions GitHub Actions
Copy link

Preview environment👷🏼‍♀️🏗️
PR-4810

@ruslandoga
Copy link
Contributor

ruslandoga commented Nov 20, 2024 •
edited
Loading

👋

Sorry for a drive-by comment on a draft PR, but if it's possible to set the attribute key to f[]= then it would get automatically decoded into a list in Plug / Phoenix. Otherwise, I think a custom decoder for query strings would need to be implemented.

More info: https://hexdocs.pm/plug/Plug.Conn.Query.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apata @ruslandoga