Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIv2: Case insensitive search #4863

Merged
merged 15 commits into from
Dec 3, 2024
Merged

APIv2: Case insensitive search #4863

merged 15 commits into from
Dec 3, 2024

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Nov 28, 2024 •
edited
Loading

Changes

This PR:

  • Adds support for case insensitive search to APIv2
  • Makes searching in details modals case-insensitive by default

Successor to https://github.com/plausible/analytics/pull/4806/files

Companion PR: plausible/docs#567

Screenshots

image

image

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog
  • This PR does not make a user-facing change

Documentation

  • Docs have been updated
  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
  • This PR does not change the UI

@macobo macobo added the preview label Nov 28, 2024
@github-actions GitHub Actions
Copy link

Preview environment👷🏼‍♀️🏗️
PR-4863

@macobo macobo mentioned this pull request Nov 29, 2024
Merged
@macobo macobo marked this pull request as ready for review November 29, 2024 14:52
@macobo macobo requested a review from a team November 29, 2024 14:52
apata
apata reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@apata apata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, works well!

test/plausible_web/controllers/api/external_stats_controller/query_test.exs Outdated Show resolved Hide resolved
test/plausible_web/controllers/api/external_stats_controller/query_imported_test.exs Show resolved Hide resolved
lib/plausible/stats/filters/query_parser.ex Outdated Show resolved Hide resolved
@macobo macobo added this pull request to the merge queue Dec 3, 2024
Merged via the queue into master with commit a38eacf Dec 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apata apata apata approved these changes

Assignees
No one assigned
Labels
preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macobo @apata