Optimization: use EventHandle in Components for scene and layers #7138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this is for merging into |
willeastcott
approved these changes
Nov 29, 2024
Editor uses engine v1, and most (except one) of our projects are v1, so we work with it in the first place. |
mvaligursky
reviewed
Dec 2, 2024
mvaligursky
approved these changes
Dec 3, 2024
mvaligursky
pushed a commit
that referenced
this pull request
Dec 3, 2024
* implement more optimized EventHandle.off * use EventHandle for scene and layers events for improved performance * more EventHandle.off in critical places * asset-reference event handlers * remove uncecessary off's --------- Co-authored-by: Will Eastcott <[email protected]>
|
cherry picked to main as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #7137
This PR uses EventHandle.off instead of EventHandler.off to improve performance when disabling renderable components. As a scene and layers callaback arrays can get large in big projects.
In large scenes, disabling renderable components became ~4-8 times faster based on our tests. In one specific scene, disabling half of a scene used to take ~3550ms now it takes ~600ms (~5.9 times improvement).
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.