Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Scalafmt settings between all repositories #28

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Sync Scalafmt settings between all repositories #28

wants to merge 1 commit into from

Conversation

ihostage
Copy link
Member

@ihostage ihostage marked this pull request as draft May 18, 2022 15:14
@ihostage ihostage force-pushed the sync-scalafmt branch 2 times, most recently from 58834f0 to 7f6ee1f Compare May 18, 2022 15:24
This was referenced Oct 7, 2022
Closed
Closed
@mkurz
Copy link
Member

mkurz commented Oct 14, 2022 •
edited
Loading

Would it make sense to also add/sync an .editorconfig file (https://editorconfig.org/)? Only the play-mailer has it right now: https://github.com/playframework/play-mailer/blob/main/.editorconfig
IntelliJ support scalafmt out of the box, however maybe it makes sense for other IDEs and editors to define some rules? (Also possible for non Scala/non Java files).
Not sure, just a thought since I saw that file in play-mailer.

@ihostage
Copy link
Member Author

Would it make sense to also add/sync an .editorconfig file (https://editorconfig.org/)?

I think yes. I think we should unify contribution rules as max as possible for simplify work contributors and maintainers when they is switching between many Play repositories.

@mkurz
Copy link
Member

mkurz commented Oct 18, 2022

Time for a sync job 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync Scalafmt settings between all repositories
2 participants
@ihostage @mkurz