fix: Trim trailing non-word characters for hostname labels

[mrseanbaines]

Fixes an issue where hostname labels end in non-word characters which prevents certain browsers (e.g. Firefox) from loading the URL

[linear]

HEI-3302 Adjust spa-tools URL builder to trim trailing slashes when a feature branch URL ends with a hyphen.

[mrseanbaines]

@macko911 is there a way to test this change in real life?

[macko911]

is there a way to test this change in real life?

@mrseanbaines It is possible but it's not trivial. I wanted to write a guide on how to do so, if you don't mind waiting until early next week I would take time today to finish it, then use you as a guinea pig to see if the guide works, wdyt? 😄
https://www.notion.so/pleo/Guide-to-test-terraform-changes-before-merging-e639098417574a97ae180e9c9b7e644f

[mrseanbaines]

is there a way to test this change in real life?

@mrseanbaines It is possible but it's not trivial. I wanted to write a guide on how to do so, if you don't mind waiting until early next week I would take time today to finish it, then use you as a guinea pig to see if the guide works, wdyt? 😄 https://www.notion.so/pleo/Guide-to-test-terraform-changes-before-merging-e639098417574a97ae180e9c9b7e644f

Ha, yep that works for me 👍

[macko911]

is there a way to test this change in real life?

@mrseanbaines It is possible but it's not trivial. I wanted to write a guide on how to do so, if you don't mind waiting until early next week I would take time today to finish it, then use you as a guinea pig to see if the guide works, wdyt? 😄 https://www.notion.so/pleo/Guide-to-test-terraform-changes-before-merging-e639098417574a97ae180e9c9b7e644f

Ha, yep that works for me 👍

The guide should be ready, feel free to add comments when something is unclear, it's pretty late so I'm not really sure it makes sense 😄