Upgrade dependencies #252
Upgrade dependencies #252
Conversation
|
Warning Rate limit exceeded@Danielius1922 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 11 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe recent changes primarily involve updates to the Go version and various GitHub Actions workflows. The Go version has been upgraded from 1.20 to 1.22 across multiple workflow files. Additionally, the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
go.modis excluded by!**/*.modgo.sumis excluded by!**/*.sum
Files selected for processing (16)
- .github/workflows/golangci-lint.yml (1 hunks)
- .golangci.yml (2 hunks)
- dependency/googleapis (1 hunks)
- service/grpc/getJSONWebKeys.go (2 hunks)
- service/grpc/jsonWebKeyCache.go (2 hunks)
- service/grpc/updateJSONWebKeys.go (1 hunks)
- service/http/clearCache_test.go (2 hunks)
- service/http/createResource.go (2 hunks)
- service/http/getDeviceResourceLinks_test.go (2 hunks)
- service/http/getDevice_test.go (2 hunks)
- service/http/getDevices_test.go (3 hunks)
- service/http/getResource_test.go (2 hunks)
- service/http/onboardDevice_test.go (4 hunks)
- service/http/ownDevice_test.go (3 hunks)
- service/http/updateResource.go (2 hunks)
- service/http/updateResource_test.go (2 hunks)
Files not reviewed due to errors (2)
- .golangci.yml (no review received)
- service/http/ownDevice_test.go (no review received)
Files skipped from review due to trivial changes (5)
- .github/workflows/golangci-lint.yml
- dependency/googleapis
- service/grpc/updateJSONWebKeys.go
- service/http/getResource_test.go
- service/http/updateResource_test.go
Additional comments not posted (19)
service/http/createResource.go (3)
25-26: Updated import paths to reflect new package structure.
35-36: Updated content type handling to use new package constants.
43-43: Improved error message for better clarity and context.service/grpc/getJSONWebKeys.go (2)
38-38: Correctly added keys to the slice.
36-36: Verify that the method change fromGettoKeyaligns with the updated API.service/http/updateResource.go (2)
29-30: Updated import paths to reflect new package structure.
67-67: Improved error message for better clarity and context.service/grpc/jsonWebKeyCache.go (2)
8-8: Updated import paths to reflect new package structure.
47-47: Enhanced algorithm comparison logic for better readability and correctness.service/http/getDeviceResourceLinks_test.go (1)
32-32: Updated import paths and method calls in test functions to align with dependency updates.Also applies to: 91-91
service/http/getDevices_test.go (1)
33-33: Updated import paths and method calls in test functions to align with dependency updates.Also applies to: 119-119
service/http/getDevice_test.go (2)
31-31: Updated import path to use the newhttpTestpackage.
71-71: Updated unmarshalling function to use the newhttpTest.Unmarshal.service/http/clearCache_test.go (2)
31-31: Updated import path to use the newhttpTestpackage.
73-73: Updated unmarshalling function to use the newhttpTest.Unmarshal.service/http/onboardDevice_test.go (4)
35-36: Updated import paths to include new packages for device testing and HTTP utilities.
46-46: Modified the test setup to include multiple services, enhancing the test's robustness.
133-133: Updated unmarshalling function to use the newhttpTest.Unmarshal.
154-154: Added a new function call to wait for device readiness, improving test reliability.
Danielius1922
force-pushed
the
adam/feature/update-deps
branch
from
a9e0e08 to
ee6752f
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
service/http/createResource.go (1)
Line range hint
30-30: Undefined references found.+ type RequestHandler struct { + mux *http.ServeMux + } + + func createContentBody(body io.Reader) (io.Reader, error) { + // Implementation goes here + return body, nil + }The
RequestHandlertype andcreateContentBodyfunction are undefined in the provided context. Define these or ensure they are imported if defined elsewhere.Also applies to: 41-41
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
go.modis excluded by!**/*.modgo.sumis excluded by!**/*.sum
Files selected for processing (15)
- dependency/googleapis (1 hunks)
- service/grpc/getJSONWebKeys.go (2 hunks)
- service/grpc/jsonWebKeyCache.go (2 hunks)
- service/grpc/updateJSONWebKeys.go (1 hunks)
- service/http/clearCache_test.go (2 hunks)
- service/http/createResource.go (2 hunks)
- service/http/getDeviceResourceLinks_test.go (2 hunks)
- service/http/getDevice_test.go (2 hunks)
- service/http/getDevices_test.go (3 hunks)
- service/http/getResource_test.go (2 hunks)
- service/http/onboardDevice_test.go (4 hunks)
- service/http/ownDevice_test.go (3 hunks)
- service/http/updateResource.go (2 hunks)
- service/http/updateResource_test.go (2 hunks)
- web/Dockerfile (1 hunks)
Files skipped from review as they are similar to previous changes (13)
- dependency/googleapis
- service/grpc/getJSONWebKeys.go
- service/grpc/jsonWebKeyCache.go
- service/grpc/updateJSONWebKeys.go
- service/http/clearCache_test.go
- service/http/getDeviceResourceLinks_test.go
- service/http/getDevice_test.go
- service/http/getDevices_test.go
- service/http/getResource_test.go
- service/http/onboardDevice_test.go
- service/http/ownDevice_test.go
- service/http/updateResource.go
- service/http/updateResource_test.go
Additional context used
golangci-lint
service/http/createResource.go
30-30: undefined: RequestHandler (typecheck)
41-41: undefined: createContentBody (typecheck)
Additional comments not posted (6)
web/Dockerfile (3)
4-4: Set the working directory to/web.This change is straightforward and aligns with best practices for Dockerfile structure.
9-9: Optimize npm configuration and installation commands.Reordering these commands for better cache utilization and setting timeouts and retries is a good practice to ensure reliable builds.
6-7: Temporary hotfix to update browserslist database.Please verify if this hotfix is still necessary or if it can be removed in a future update.
service/http/createResource.go (3)
25-26: Update import paths to use more specific packages.Switching to more specific packages (
pkgGrpcandpkgHttp) instead of generic ones improves modularity and clarity in the codebase.
35-36: Use constants frompkgHttpfor content type checks.Using constants for content types enhances code readability and maintainability by avoiding hard-coded strings.
43-43: Improve error handling by usingpkgGrpc.ForwardErrorf.This change standardizes error handling and improves the error message clarity by including specific resource identifiers in the message.
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
go.modis excluded by!**/*.modgo.sumis excluded by!**/*.sum
Files selected for processing (6)
- .github/workflows/buildTestBinaries.yml (1 hunks)
- .github/workflows/checkFormat.yml (1 hunks)
- .github/workflows/golangci-lint.yml (1 hunks)
- .github/workflows/release.yml (2 hunks)
- .github/workflows/test.yml (1 hunks)
- .golangci.yml (3 hunks)
Files skipped from review due to trivial changes (3)
- .github/workflows/buildTestBinaries.yml
- .github/workflows/checkFormat.yml
- .github/workflows/test.yml
Files skipped from review as they are similar to previous changes (2)
- .github/workflows/golangci-lint.yml
- .golangci.yml
Additional comments not posted (1)
.github/workflows/release.yml (1)
71-71: Change to GoReleaser version constraint approved.Verification successful
The change to use the version constraint
~> v1for GoReleaser is appropriate. The listed versions indicate that thev1series is actively maintained and includes recent stable releases.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the stability and features of GoReleaser `~> v1`. # Test: Check the release notes of GoReleaser for the specified version range to ensure it meets the project's needs. gh release view --repo goreleaser/goreleaser --pattern '~> v1'Length of output: 420
Script:
#!/bin/bash # Description: Verify the stability and features of GoReleaser `~> v1`. # Fetch the list of releases from the GoReleaser repository and filter for versions that match `~> v1`. gh release list --repo goreleaser/goreleaser --limit 100 | grep -E '^v1\.' | head -n 10Length of output: 494
Danielius1922
force-pushed
the
adam/feature/update-deps
branch
2 times, most recently
from
3ed3107 to
d8f3e17
Compare
golangci/golangci-lint-action: v5 -> v6
Golang: 1.22 Submodule: github.com/googleapis/googleapis 716a2814e199eeef8fd9f3e11418ee0881ac833a Direct: github.com/goreleaser/goreleaser v1.26.2 github.com/grpc-ecosystem/grpc-gateway/v2 v2.20.0 github.com/lestrrat-go/jwx/v2 v2.0.21 github.com/pion/dtls/v2 v2.2.8-0.20240601040544-edc7ad02205f github.com/plgd-dev/device/v2 v2.5.2-0.20240603131607-6c9b1dc14b00 github.com/plgd-dev/go-coap/v3 v3.3.5-0.20240603125124-ff2c47df37c4 github.com/plgd-dev/hub/v2 v2.19.1 go.opentelemetry.io/otel/trace v1.27.0 google.golang.org/grpc v1.64.0 google.golang.org/protobuf v1.34.1
Danielius1922
force-pushed
the
adam/feature/update-deps
branch
from
d8f3e17 to
1e7f6d0
Compare
|
Summary by CodeRabbit
1.20to1.22to ensure compatibility and leverage new features.golangci-lintaction version fromv5tov6for improved linting capabilities.