Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed transfer API validation #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion plivo/resources/calls.py
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ def get(self, call_uuid):
)
def update(self,
call_uuid,
legs=None,
legs,
aleg_url=None,
aleg_method=None,
bleg_url=None,
Expand All @@ -249,6 +249,21 @@ def transfer(self,
aleg_method=None,
bleg_url=None,
bleg_method=None):
if legs is None:
raise ValidationError(
'Which leg of the call should be transfered? aleg,bleg or both?')
elif (legs == 'aleg' and aleg_url is None):
raise ValidationError(
'aleg is mentioned. Please mention aleg_url as well'
)
elif (legs == 'bleg' and bleg_url is None):
raise ValidationError(
'bleg is mentioned. Please mention bleg_url as well'
)
elif (legs == 'both' and (aleg_url is None and bleg_url is None)):
raise ValidationError(
'both legs are mentioned. Please mention both aleg_url and bleg_url'
)
return self.update(
call_uuid,
legs=legs,
Expand Down