deploy/argo - use tag rather then branch for revision so that prod do…

…esn't get updated when updating helm chart values for test both of which currently point at 'main' branch in the argo config
ploigos · Sep 10, 2021 · df6ec0c · df6ec0c
1 parent 65f63d9
commit df6ec0c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/ploigos_step_runner/step_implementers/deploy/argocd.py b/src/ploigos_step_runner/step_implementers/deploy/argocd.py
@@ -332,7 +332,7 @@ def _run_step(self):  # pylint: disable=too-many-locals
             ArgoCD.__argocd_app_create_or_update(
                 argocd_app_name=argocd_app_name,
                 repo=deployment_config_repo,
-                revision=deployment_config_repo_branch,
+                revision=deployment_config_repo_tag,
                 path=deployment_config_helm_chart_path,
                 dest_server=deployment_config_destination_cluster_uri,
                 auto_sync=self.get_value('argocd-auto-sync'),

diff --git a/tests/step_implementers/deploy/test_argocd.py b/tests/step_implementers/deploy/test_argocd.py
@@ -363,7 +363,7 @@ def test_ArgoCD_run_step_success(
             argocd_app_create_or_update_mock.assert_called_once_with(
                 argocd_app_name='test-app-name',
                 repo=step_config['deployment-config-repo'],
-                revision='feature/test',
+                revision='v0.42.0',
                 path=step_config['deployment-config-helm-chart-path'],
                 dest_server='https://kubernetes.default.svc',
                 auto_sync=True,
@@ -518,7 +518,7 @@ def test_ArgoCD_run_step_success_no_prune(
             argocd_app_create_or_update_mock.assert_called_once_with(
                 argocd_app_name='test-app-name',
                 repo=step_config['deployment-config-repo'],
-                revision='feature/test',
+                revision='v0.42.0',
                 path=step_config['deployment-config-helm-chart-path'],
                 dest_server='https://kubernetes.default.svc',
                 auto_sync=True,
@@ -673,7 +673,7 @@ def test_ArgoCD_run_step_success_additional_helm_values_files(
             argocd_app_create_or_update_mock.assert_called_once_with(
                 argocd_app_name='test-app-name',
                 repo=step_config['deployment-config-repo'],
-                revision='feature/test',
+                revision='v0.42.0',
                 path=step_config['deployment-config-helm-chart-path'],
                 dest_server='https://kubernetes.default.svc',
                 auto_sync=True,