-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config with plone.meta and drop pkg_resources #15
base: master
Are you sure you want to change the base?
Conversation
`pkg_resources` is there "always", though it is deprecated as well :-)
@gforcada thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
2f043f6
to
dc164c6
Compare
See plone/Products.CMFPlone#4126
Before dropping
pkg_resources
there is a slew of commits that handle the usualplone.meta
configuration 😄Warning
This
pkg_resources
replacement is a bit more involved, so testing with actual code would be useful, as test coverage for that part does not exist 🤦🏾