Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config with plone.meta and drop pkg_resources #15

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

gforcada
Copy link
Member

See plone/Products.CMFPlone#4126

Before dropping pkg_resources there is a slew of commits that handle the usual plone.meta configuration 😄

Warning

This pkg_resources replacement is a bit more involved, so testing with actual code would be useful, as test coverage for that part does not exist 🤦🏾

@mister-roboto
Copy link

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@gforcada gforcada force-pushed the config-with-default-template-2.0.1.dev0 branch from 2f043f6 to dc164c6 Compare March 1, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants