-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix myst sphinx warnings #3035
Fix myst sphinx warnings #3035
Conversation
Remove comments that are obsolete Add html_meta values
Add html_meta values
Remove redundant directory listing Add html_meta values
Remove `./` Fix syntax highlighting and emphasis Fix broken references Add html_meta values
Add html_meta values
Quick syntax question for y'all. I'm working on fixing the <SidebarPortal selected={this.props.selected}>
<InlineForm
icon={<Icon size="24px" name={nameSVG} />}
schema={schema}
title={schema.title}
headerActions={<button onClick={() => {}}>Action</button>}
footer={<div>I'm footer</div>}
onChangeField={(id, value) => {
this.props.onChangeBlock(this.props.block, {
...this.props.data,
[id]: value,
});
}}
formData={this.props.data}
/>
</SidebarPortal>; ...but if I quote the HTML values, then it does parse: <SidebarPortal selected={this.props.selected}>
<InlineForm
icon={"<Icon size="24px" name={nameSVG} />"}
schema={schema}
title={schema.title}
headerActions={"<button onClick={() => {}}>Action</button>"}
footer={"<div>I'm footer</div>"}
onChangeField={(id, value) => {
this.props.onChangeBlock(this.props.block, {
...this.props.data,
[id]: value,
});
}}
formData={this.props.data}
/>
</SidebarPortal>; My question is whether the latter form is valid syntax when actually used as code? It would be great if someone could run a quick test for me, perhaps a simple To go along with this, we need to make a choice about sytnax highlighting for jsx.
|
Add html_meta values
Add html_meta values
Add html_meta values
Adjust references
Add html_meta values
Minor grammar fixes Add html_meta values
Remove unused lexer parameter Add html_meta values
Add html_meta values
Add html_meta values
Add html_meta values
Add html_meta values
Fix reference to openobjectbrowser-handler-api-label Add html_meta values
@stevepiercy no, |
I reverted those incorrect "fixes". I opened an issue here #3038 and fcurella/jsx-lexer#15
We can do without syntax highlighting for now, but someone who understands the lexer and jsx syntax should submit a PR to the project. |
It turns out that |
This PR is now ready for final review. Any takers? |
This PR uses the branch
add-myst-sphinx-config
to build the docs for testing. This PR should be merged into #3032 before the other is merged intoplone6-docs