Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Blocks/LeadImage/Edit component #4959

Merged
merged 20 commits into from
Aug 13, 2024
Merged

Conversation

Tishasoumya-02
Copy link
Contributor

@netlify
Copy link

netlify bot commented Jul 8, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 68c1463
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/64eeea51a2d7cc0008df3586

@cypress
Copy link

cypress bot commented Jul 8, 2023

Passing run #7062 ↗︎

0 561 20 0 Flakiness 0

Details:

Merge branch 'block-leadimage-refactor' of https://github.com/plone/volto into b...
Project: Volto Commit: 68c1463c35
Status: Passed Duration: 18:35 💡
Started: Aug 30, 2023 7:09 AM Ended: Aug 30, 2023 7:27 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@nileshgulia1
Copy link
Member

@Tishasoumya-02 Can you pls take care of conflicts?

@iFlameing
Copy link
Member

@sneridagh I am not able to test it locally because the backend is providing the data.
@Tishasoumya-02 @nileshgulia1 can you please tell me the steps to see the lead image locally? In this way, I will be sure everything works like old ways. please!

@nileshgulia1
Copy link
Member

@sneridagh I am not able to test it locally because the backend is providing the data. @Tishasoumya-02 @nileshgulia1 can you please tell me the steps to see the lead image locally? In this way, I will be sure everything works like old ways. please!

@iFlameing Try to add a image in Lead image behaviour in your content-type and then add a lead image block.

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 0e2f35f
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66bb2f3c3b0a060008470a51

@davisagli davisagli merged commit 8acb3b6 into main Aug 13, 2024
70 checks passed
@davisagli davisagli deleted the block-leadimage-refactor branch August 13, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants