Fixes imports to avoid type errors in addons tests #6245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we shadow a module in an addon and this module is imported relatively in some .ts file used in the addon tests, we receive the error: Could not find a declaration file for module './Module'. '../Module.jsx' implicitly has an 'any' type So we use absolute import in .ts files to avoid this problem.
✅ Deploy Preview for plone-components canceled.
|
ichim-david
approved these changes
Aug 8, 2024
stevepiercy
requested changes
Aug 8, 2024
stevepiercy
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we shadow a module in an addon and this module is imported relatively in some
.tsfile used in the addon tests, we receive the error:So we use absolute import in
.tsfiles to avoid this problem.Fixes #6244