Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing for-attribute #6249

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Add missing for-attribute #6249

merged 5 commits into from
Sep 24, 2024

Conversation

Gomez
Copy link
Member

@Gomez Gomez commented Aug 12, 2024

We had an a11y audit, these improvements were noted.

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit c7f28a5
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66f271b2bcab080008a5df7a

@Gomez Gomez changed the title Add missing for-attribute Add missing for-attribute & label to search input Aug 12, 2024
@JeffersonBledsoe
Copy link
Member

@plone/volto-accessibility Needs review

@JeffersonBledsoe JeffersonBledsoe added the 99 tag: UX Accessibility Accessibility issues label Aug 12, 2024
@Gomez Gomez force-pushed the improve-checkbox-a11y branch from 146e718 to 4936689 Compare August 12, 2024 10:18
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes should describe all changes. Also added some MyST markup for inline literals.

packages/components/news/6249.fix Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Collaborator

The failing changelog check is a lie, and can be ignored. See #6232.

The failing tests, however, cannot be ignored and must pass. I restarted them in case it was flaky and temporary.

@ichim-david ichim-david self-requested a review August 14, 2024 05:18
@erral erral self-requested a review August 14, 2024 07:22
Copy link
Member

@erral erral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't change the working of the widget, just adds a11y tags. Working as expected.

Copy link
Member

@ichim-david ichim-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gomez Gomez force-pushed the improve-checkbox-a11y branch from 4936689 to 85f08bc Compare August 23, 2024 07:02
@Gomez
Copy link
Member Author

Gomez commented Aug 23, 2024

Thanks @ichim-david! This is a useful comment, i removed the duplication.

Changelog updated with @stevepiercy comments.

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog is good. @ichim-david will review upon his return, or someone else can do a technical review.

@Gomez Gomez changed the title Add missing for-attribute & label to search input Add missing for-attribute Aug 23, 2024
@ichim-david
Copy link
Member

@Gomez I'll work on this tomorrow as part of the Salamina sprint.

@ichim-david ichim-david self-assigned this Sep 24, 2024
@ichim-david ichim-david self-requested a review September 24, 2024 08:56
Copy link
Member

@ichim-david ichim-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged now. The fix was good although I had to improve it due to how the checkbox component works
https://github.com/Semantic-Org/Semantic-UI-React/blob/master/src/modules/Checkbox/Checkbox.js#L201
By passing the id the label gets the htmlFor from the component without us needing to add it manually

@ichim-david ichim-david merged commit 6429d49 into main Sep 24, 2024
70 checks passed
@ichim-david ichim-david deleted the improve-checkbox-a11y branch September 24, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
99 tag: UX Accessibility Accessibility issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants