-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:Order blocks in sidebar doesn't respect layout restrictions: requ… #6489
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for plone-components canceled.
|
…ired and fixed position
719a285
to
10fb29c
Compare
@plone/volto-team I have made the appropriate changes to fix the issue and It works as wanted please If you can review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my note about the change log entry.
Otherwise, this looks really good, but it should get a thorough technical review by the @plone/volto-team. Thank you!
@@ -0,0 +1 @@ | |||
Fixed Order blocks in sidebar doesn't respect layout restrictions by setting appropriate handlers in `Item.jsx`. @alihamza1221 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good change log entry explicitly states what problem you fixed, not how you fixed it. The original message essentially said, "Fixed _____ by writing code in a specific file". See https://6.docs.plone.org/contributing/index.html#change-log-entry after the Important
admonition for details.
Fixed Order blocks in sidebar doesn't respect layout restrictions by setting appropriate handlers in `Item.jsx`. @alihamza1221 | |
While editing a block, and in the sidebar under the {guilabel}`Settings` tab, when an item has {guilabel}`Required` checked, then it can no longer be deleted under the {guilabel}`Order`. Similarly, when {guilabel}`Fixed position` is checked, the item's ordered position can no longer be changed. Previously neither option was honored. @alihamza1221 |
fixed : Order blocks in sidebar doesn't respect layout restrictions: required and fixed position
I added the checks to display the delete block and drag block button according to values set like fixed and required.
After my change:
order.block.fixes.video.mp4
Closes #6481