Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Order blocks in sidebar doesn't respect layout restrictions: requ… #6489

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alihamza1221
Copy link

@alihamza1221 alihamza1221 commented Nov 18, 2024


fixed : Order blocks in sidebar doesn't respect layout restrictions: required and fixed position

I added the checks to display the delete block and drag block button according to values set like fixed and required.
After my change:

order.block.fixes.video.mp4

Closes #6481

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 10fb29c
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6740240a8a5f430008f7f779

@alihamza1221 alihamza1221 marked this pull request as ready for review November 22, 2024 06:46
@alihamza1221
Copy link
Author

@plone/volto-team I have made the appropriate changes to fix the issue and It works as wanted please If you can review this PR.

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my note about the change log entry.

Otherwise, this looks really good, but it should get a thorough technical review by the @plone/volto-team. Thank you!

@@ -0,0 +1 @@
Fixed Order blocks in sidebar doesn't respect layout restrictions by setting appropriate handlers in `Item.jsx`. @alihamza1221
Copy link
Collaborator

@stevepiercy stevepiercy Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good change log entry explicitly states what problem you fixed, not how you fixed it. The original message essentially said, "Fixed _____ by writing code in a specific file". See https://6.docs.plone.org/contributing/index.html#change-log-entry after the Important admonition for details.

Suggested change
Fixed Order blocks in sidebar doesn't respect layout restrictions by setting appropriate handlers in `Item.jsx`. @alihamza1221
While editing a block, and in the sidebar under the {guilabel}`Settings` tab, when an item has {guilabel}`Required` checked, then it can no longer be deleted under the {guilabel}`Order`. Similarly, when {guilabel}`Fixed position` is checked, the item's ordered position can no longer be changed. Previously neither option was honored. @alihamza1221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order blocks in sidebar doesn't respect layout restrictions: required and fixed position
2 participants