Removed all imports from barrel files for components, actions, helpers, hooks and lodash #6509
+1,324
−1,046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, hooks and lodash
✅ Deploy Preview for plone-components canceled.
|
pnicolli
commented
Dec 2, 2024
Comment on lines
+36
to
+52
| "import/named": "error", | ||
| "react/jsx-filename-extension": [1, { "extensions": [".tsx", ".jsx"] }], | ||
| "no-restricted-imports": [ | ||
| "error", | ||
| { | ||
| "name": "@plone/volto/components", | ||
| "message": "Importing from barrel files is not allowed. Please use direct imports of the modules instead." | ||
| }, | ||
| { | ||
| "name": "@plone/volto/helpers", | ||
| "message": "Importing from barrel files is not allowed. Please use direct imports of the modules instead." | ||
| }, | ||
| { | ||
| "name": "@plone/volto/actions", | ||
| "message": "Importing from barrel files is not allowed. Please use direct imports of the modules instead." | ||
| } | ||
| ], |
There was a problem hiding this comment.
@sneridagh this eslint setup for some reason still doesn't work in the editor for me so I could properly try this.
|
@stevepiercy I realized the deprecation docs for this already existed, I added a couple extra files I cleaned up. |
|
FYI: this PR also reduces the main |
stevepiercy
requested changes
Dec 3, 2024
Co-authored-by: Steve Piercy <[email protected]>
@stevepiercy All manually :) I figured that I would have had a lot of 30 to 60 minutes slots during the conf sprint, the following day, the flights and the long layovers, so this task would have been a good fit |
stevepiercy
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6507