Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @plone/* packages info #6521

Merged
merged 3 commits into from
Dec 8, 2024
Merged

Conversation

sneridagh
Copy link
Member

No description provided.

@sneridagh sneridagh requested a review from stevepiercy December 8, 2024 11:38
Copy link

netlify bot commented Dec 8, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 6f3ba7d
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6755a7d7fb42e700080fc5a2

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double-check my suggestions for accuracy.

PACKAGES.md Outdated Show resolved Hide resolved
PACKAGES.md Outdated Show resolved Hide resolved
PACKAGES.md Outdated Show resolved Hide resolved
PACKAGES.md Outdated Show resolved Hide resolved
PACKAGES.md Outdated Show resolved Hide resolved
PACKAGES.md Outdated
- `@plone/providers`
- `@plone/helpers`
- `@plone/drivers`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave these sorted alphabetically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've ordered by relevance to me, due to the current state of things (drivers and rsc are not a thing yet). It just occurred to me that if they do not exist yet, let's remove them.

- `@plone/slots`
- `@plone/theming`
- `@plone/contents`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave these sorted alphabetically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, but if you think it's valuable, let's do it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, relevance is arbitrary to the developer. Alpha also makes it easier to find in a list.

PACKAGES.md Outdated Show resolved Hide resolved
PACKAGES.md Outdated Show resolved Hide resolved
PACKAGES.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After resolving sorting of thingies, I approve, too.

@sneridagh sneridagh merged commit cfea4d9 into main Dec 8, 2024
67 of 68 checks passed
@sneridagh sneridagh deleted the updatePloneFrontendPackagesInfo branch December 8, 2024 15:35
sneridagh added a commit that referenced this pull request Dec 12, 2024
* main:
  Fixed types declaration extractor from Volto core, re-enable it on release (#6534)
  Release 18.3.0
  Release @plone/slate 18.0.4
  Release @plone/helpers 1.0.0
  Make helpers release-able
  Release @plone/registry 2.2.0
  Release @plone/components 3.0.0
  Release @plone/types 1.1.0
  [slots] @plone/slots first developments (#6409)
  improve link integrity popup (#6516)
  Add missing styleWrapper style builder information in container/Grid (#6527)
  update: skip scroll to top on inital SSR completion. (#6523)
  Release 18.2.3
  Fixed circular import error in dev with HMR in core Views and Widgets shadow customizations (#6526)
  Release 18.2.2
  Fixed circular import error in dev with HMR in core Blocks shadow customizations (#6525)
  Release 18.2.1
  Release @plone/slate 18.0.3
  Fixed circular import error in dev with HMR in `App` component when imported in the main default config (#6524)
  Update @plone/* packages info (#6521)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants