-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @plone/* packages info #6521
Conversation
✅ Deploy Preview for plone-components canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double-check my suggestions for accuracy.
PACKAGES.md
Outdated
- `@plone/providers` | ||
- `@plone/helpers` | ||
- `@plone/drivers` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you leave these sorted alphabetically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've ordered by relevance to me, due to the current state of things (drivers and rsc are not a thing yet). It just occurred to me that if they do not exist yet, let's remove them.
- `@plone/slots` | ||
- `@plone/theming` | ||
- `@plone/contents` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you leave these sorted alphabetically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, but if you think it's valuable, let's do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, relevance is arbitrary to the developer. Alpha also makes it easier to find in a list.
Co-authored-by: Steve Piercy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After resolving sorting of thingies, I approve, too.
* main: Fixed types declaration extractor from Volto core, re-enable it on release (#6534) Release 18.3.0 Release @plone/slate 18.0.4 Release @plone/helpers 1.0.0 Make helpers release-able Release @plone/registry 2.2.0 Release @plone/components 3.0.0 Release @plone/types 1.1.0 [slots] @plone/slots first developments (#6409) improve link integrity popup (#6516) Add missing styleWrapper style builder information in container/Grid (#6527) update: skip scroll to top on inital SSR completion. (#6523) Release 18.2.3 Fixed circular import error in dev with HMR in core Views and Widgets shadow customizations (#6526) Release 18.2.2 Fixed circular import error in dev with HMR in core Blocks shadow customizations (#6525) Release 18.2.1 Release @plone/slate 18.0.3 Fixed circular import error in dev with HMR in `App` component when imported in the main default config (#6524) Update @plone/* packages info (#6521)
No description provided.