Skip to content

Commit

Permalink
Merge pull request #3080 from plotly/alexcjohnson-patch-1
Browse files Browse the repository at this point in the history
More flexible reading of component docstrings
  • Loading branch information
alexcjohnson authored Nov 18, 2024
2 parents 9566578 + 021f540 commit 22891e1
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
10 changes: 8 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
All notable changes to `dash` will be documented in this file.
This project adheres to [Semantic Versioning](https://semver.org/).

## [UNRELEASED]

## Fixed

- [#3080](https://github.com/plotly/dash/pull/3080) Fix docstring generation for components using single-line or nonstandard-indent leading comments

## [2.18.2] - 2024-11-04

## Fixed
Expand Down Expand Up @@ -89,7 +95,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
## Fixed

- [#2362](https://github.com/plotly/dash/pull/2362) Global namespace not polluted any more when loading clientside callbacks.
- [#2833](https://github.com/plotly/dash/pull/2833) Allow data url in link props. Fixes [#2764](https://github.com/plotly/dash/issues/2764)
- [#2833](https://github.com/plotly/dash/pull/2833) Allow data url in link props. Fixes [#2764](https://github.com/plotly/dash/issues/2764)
- [#2822](https://github.com/plotly/dash/pull/2822) Fix side update (running/progress/cancel) dict ids. Fixes [#2111](https://github.com/plotly/dash/issues/2111)
- [#2817](https://github.com/plotly/dash/pull/2817) Change hashing algorithm from md5 to sha256, Fixes [#2697](https://github.com/plotly/dash/issues/2697).
- [#2816](https://github.com/plotly/dash/pull/2816) Fix dcc.Dropdown value not updated when option is removed. Fixes [#2733](https://github.com/plotly/dash/issues/2733).
Expand All @@ -116,7 +122,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
## Added
- [#2762](https://github.com/plotly/dash/pull/2762) Add dynamic loading of component libraries.
- Add `dynamic_loading=True` to dash init.
- Add `preloaded_libraries=[]` to dash init, included libraries names will be loaded on the index like before.
- Add `preloaded_libraries=[]` to dash init, included libraries names will be loaded on the index like before.
- [#2758](https://github.com/plotly/dash/pull/2758)
- exposing `setProps` to `dash_clientside.clientSide_setProps` to allow for JS code to interact directly with the dash eco-system
- [#2730](https://github.com/plotly/dash/pull/2721) Load script files with `.mjs` ending as js modules
Expand Down
4 changes: 2 additions & 2 deletions dash/extract-meta.js
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,7 @@ function gatherComponents(sources, components = {}) {

if (propsType) {
if (
propsType.valueDeclaration &&
propsType.valueDeclaration &&
propsType.valueDeclaration.name &&
propsType.valueDeclaration.name.elements &&
propsType.valueDeclaration.name.elements.length
Expand Down Expand Up @@ -762,7 +762,7 @@ function gatherComponents(sources, components = {}) {
fullText
.slice(r.pos + 4, r.end - 3)
.split('\n')
.map(s => s.slice(3, s.length))
.map(s => s.replace(/^(\s*\*?\s)/, ''))
.filter(e => e)
.join('\n')
)
Expand Down

0 comments on commit 22891e1

Please sign in to comment.