Add generated caller filename hash as clientside callback namespace. #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T4rk1n
requested review from
alexcjohnson,
ndrezn,
gvwilson and
emilykl
as code owners
gvwilson
approved these changes
Feb 13, 2025
gvwilson
reviewed
Feb 13, 2025
| # Generate the hash from the caller filename. | ||
| caller = get_caller_name() | ||
| module = importlib.import_module(caller) | ||
| namespace = hashlib.sha256(module.__file__.encode("utf-8")).hexdigest() |
|
Repeating from dash-embedded thread, the inline scripts are added to the scripts tag on the index but that is not recommended for security purpose and doesn't allow caching. We need to bring the functionality on embedded that created a new route for the inline scripts and added it to the scripts to load. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://github.com/plotly/dash-embedded/issues/87
Generate hash from the
clientside_callbackcaller filename to use as namespace, this will make it unique instead of modifying the namespace in dash-embedded.