Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable storing the callback outputs in the persistence storage with the flag #3173

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

petar-qb
Copy link

@petar-qb petar-qb commented Feb 20, 2025

This PR is similar to #3144. It solves the same issue but with an additional optional callback flag called enable_persistence.
This PR behaves more like a feature, and the other (original) one (#3144) more like a bugfix.

Description:
Add enable_persistence that when True enables storing the callback outputs in the persistence storage.

@gvwilson gvwilson added feature something new P1 needed for current cycle community community contribution labels Feb 20, 2025
@gvwilson
Copy link
Contributor

cc @T4rk1n

@ndrezn
Copy link
Member

ndrezn commented Feb 20, 2025

My understanding is that this PR is parallel with #3144, we either merge this or #3144 (but not both!) depending on whether we want to have this as a flag or a default behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new P1 needed for current cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants