Small welcome panel optimisation

plugdata-team · Dec 4, 2024 · 30836b8 · 30836b8
1 parent fc21731
commit 30836b8
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 5 deletions.
diff --git a/Source/Components/WelcomePanel.h b/Source/Components/WelcomePanel.h
@@ -804,7 +804,15 @@ class WelcomePanel : public Component
                 }
                 if (thumbImage.isNull()) {
                     if (patchFile.existsAsFile()) {
-                        silhoutteSvg = OfflineObjectRenderer::patchToSVG(patchFile.loadFileAsString());
+                        auto cachedSilhouette = patchSvgCache.find(patchFile.getFullPathName());
+                        if(cachedSilhouette != patchSvgCache.end())
+                        {
+                            silhoutteSvg = cachedSilhouette->second;
+                        }
+                        else {
+                            silhoutteSvg = OfflineObjectRenderer::patchToSVG(patchFile.loadFileAsString());
+                            patchSvgCache[patchFile.getFullPathName()] = silhoutteSvg;
+                        }
                     }
                 }
 
@@ -949,6 +957,7 @@ class WelcomePanel : public Component
 
     String searchQuery;
     Tab currentTab = Home;
+    UnorderedMap<String, String> patchSvgCache;
 
     // To make the library panel update automatically
     class LibraryFSListener : public FileSystemWatcher::Listener

diff --git a/Source/Pd/Library.cpp b/Source/Pd/Library.cpp
@@ -345,11 +345,8 @@ File Library::findFile(String const& fileToFind)
     auto pathTree = SettingsFile::getInstance()->getValueTree().getChildWithName("Paths");
     for (auto path : pathTree) {
         auto searchPath = File(path.getProperty("Path").toString());
-        if (!searchPath.exists() || !searchPath.isDirectory())
-            continue;
-
         auto childFile = searchPath.getChildFile(fileToFind);
-        if (childFile.existsAsFile())
+        if (OSUtils::isFileFast(childFile.getFullPathName()))
             return childFile;
     }
 

diff --git a/Source/Utility/OSUtils.cpp b/Source/Utility/OSUtils.cpp
@@ -307,6 +307,11 @@ bool OSUtils::isDirectoryFast(juce::String const& path)
     return fs::is_directory(path.toStdString());
 }
 
+bool OSUtils::isFileFast(juce::String const& path)
+{
+    return fs::is_regular_file(path.toStdString());
+}
+
 hash32 OSUtils::getUniqueFileHash(juce::String const& path)
 {
     return hash(fs::canonical(path.toStdString()).c_str());

diff --git a/Source/Utility/OSUtils.h b/Source/Utility/OSUtils.h
@@ -40,6 +40,7 @@ struct OSUtils {
 
     static SmallArray<juce::File> iterateDirectory(juce::File const& directory, bool recursive, bool onlyFiles, int maximum = -1);
     static bool isDirectoryFast(juce::String const& path);
+    static bool isFileFast(juce::String const& path);
     static hash32 getUniqueFileHash(juce::String const& path);
 
     static KeyboardLayout getKeyboardLayout();