add CI #372
Merged
add CI #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrienClairembault
requested changes
Feb 22, 2024
There was a problem hiding this comment.
I think you are missing the required php dependencies.
For example, here are the depencies of the tag plugin: https://github.com/pluginsGLPI/tag/blob/main/composer.json
edit: if you added the eslinted too, don't forget about client side dependencies too.
|
|
stonebuzz
approved these changes
Feb 23, 2024
|
Too much code to modify for PHPStan, I think we'll have to dedicate a PR for its activation. EDIT: I finally disabled phpstan completely and renamed the conf file to |
AdrienClairembault
approved these changes
Feb 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CI