feat(sccm): Works with multiple configurations #120
Conversation
|
Yeah! :D I have fix some odd things that made that menu didn't work at expected. I will prepare the commit and push here. |
tolemac
force-pushed
the
multi
branch
2 times, most recently
from
3829d0e to
b71492f
Compare
|
Done! it's ready for review. It has add button and the configs can be purged, config form use standard form html with navigation and historical log. |
inc/config.class.php
Outdated
| NULL)"; | ||
|
|
||
| $DB->queryOrDie($query, __("Error when using glpi_plugin_sccm_configs table.", "sccm") | ||
| . "<br />" . $DB->error()); | ||
|
|
||
| } else { | ||
| if (!self::isIdAutoIncrement()) |
There was a problem hiding this comment.
why did you alter ID column from autoincrement to autoincrement ?
for me, you just need to test whether the name and collection fields are present, otherwise add them
|
@stonebuzz how to have the commits to keep your commits? |
|
git fetch my_repo (yours) git pull --rebase my_repo my_branch (multi) |
|
@stonebuzz I have a question, what is the |
an old thing that's about to blow up ^^ don't worry about it now, I'll clean up later |
|
Let me know when you've finished so I can do another review |
I think the only thing missing is the autoincrement issue, I have answered the review, I'm waiting for your response. |
|
Hi @tolemac I've corrected and refactored the code. Can you try this new version? |
I have pushed the code to production. I have deactivate de plugin, and reactivate it. I have execute on demand Collect and Push automatic actions. All work as expected, no errors on It's ok for me. |
|
Thanks, @tolemac, I'll have it tested by a few people who use it before I merge it. |
Totally agree! Thanks in advance. I will stay tunned. |
|
@stonebuzz some news about that? still in testing? Best regards! |
Hi again!
I have fear about #109, this PR have serious changes and we are working in production with code that is not in this repository, after #109 has been merged I think it will be more difficult for us to add this change, due to it we would like to make a effort to add this PR to the repo.
This PR is the same as #102, we think that it's a good feature and it has been working all days in the last year in our GLPI installation.
The feature is fully functional the only thing missing is a button to add a new SCCM Configuration.
I would like to add this but I haven't been able to...
Can you help me?