Merge remote-tracking branch 'origin/v2.9'

plumed · Sep 25, 2023 · 6fdf4bd · 6fdf4bd · PlumedBot · Sep 25, 2023
2 parents 9923978 + 7bea3b9
commit 6fdf4bd
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 7 deletions.
diff --git a/CHANGES/v2.9.md b/CHANGES/v2.9.md
@@ -53,4 +53,5 @@ Changes from version 2.8 which are relevant for users:
   - Plumed patch now accepts the `--include` option. Might become the default in a future version.
   - Python (cython) wrappers now only use plain C instead of C++. Plumed exceptions are mapped to python exceptions.
   - Step number is now stored as a `long long int`. Might facilitate Windows compatibility.
+  - Plumed now fetches the massses correctly from QEspresso 7.0
 
diff --git a/patches/qespresso-6.2.diff/PW/src/plugin_ext_forces.f90 b/patches/qespresso-6.2.diff/PW/src/plugin_ext_forces.f90
@@ -18,19 +18,21 @@ SUBROUTINE plugin_ext_forces()
   USE plugin_flags
   !
   USE cell_base,        ONLY : alat, at
-  USE ions_base,        ONLY : tau, nat,amass
+  USE ions_base,        ONLY : tau, nat, amass, ityp
   USE force_mod,        ONLY : force,sigma
   USE control_flags,    ONLY : istep
   USE ener,             ONLY : etot 
   !
   IMPLICIT NONE
   !
-  INTEGER:: i,j
+  INTEGER:: i,j,ia
   REAL(DP) :: at_plumed(3,3)
   REAL(DP) :: virial(3,3)
   REAL(DP) :: volume
   REAL(DP), ALLOCATABLE :: tau_plumed(:,:)
+  REAL(DP) :: masses_plumed(nat)
   !
+  masses_plumed = 0.0_DP
   IF(use_plumed) then
     IF(ionode)THEN
       at_plumed=alat*at;  ! the cell, rescaled properly
@@ -43,9 +45,12 @@ SUBROUTINE plugin_ext_forces()
              -at_plumed(1,2)*at_plumed(3,3)*at_plumed(2,1) &
              -at_plumed(1,3)*at_plumed(3,1)*at_plumed(2,2) 
       virial=-sigma*volume
-
+      ! the masses in QE are stored per type, see q-e//Modules/ions_base.f90
+      do ia=1,nat
+        masses_plumed(ia)=amass(ityp(ia))
+      end do
       CALL plumed_f_gcmd("setStep"//char(0),istep)
-      CALL plumed_f_gcmd("setMasses"//char(0),amass)
+      CALL plumed_f_gcmd("setMasses"//char(0),masses_plumed)
       CALL plumed_f_gcmd("setForces"//char(0),force)
       CALL plumed_f_gcmd("setPositions"//char(0),tau_plumed)
       CALL plumed_f_gcmd("setBox"//char(0),at_plumed)

diff --git a/patches/qespresso-7.0.diff/PW/src/plugin_ext_forces.f90 b/patches/qespresso-7.0.diff/PW/src/plugin_ext_forces.f90
@@ -18,7 +18,7 @@ SUBROUTINE plugin_ext_forces()
   USE plugin_flags,     ONLY : use_plumed
   !
   USE cell_base,        ONLY : alat, at
-  USE ions_base,        ONLY : tau, nat,amass
+  USE ions_base,        ONLY : tau, nat, amass, ityp
   USE force_mod,        ONLY : force,sigma
   USE control_flags,    ONLY : istep
   USE ener,             ONLY : etot 
@@ -27,12 +27,14 @@ SUBROUTINE plugin_ext_forces()
   !
   IMPLICIT NONE
   !
-  INTEGER:: i,j
+  INTEGER:: i,j,ia
   REAL(DP) :: at_plumed(3,3)
   REAL(DP) :: virial(3,3)
   REAL(DP) :: volume
   REAL(DP), ALLOCATABLE :: tau_plumed(:,:)
+  REAL(DP) :: masses_plumed(nat)
   !
+  masses_plumed = 0.0_DP
   IF(use_plumed) then
     IF(ionode)THEN
       at_plumed=alat*at;  ! the cell, rescaled properly
@@ -46,8 +48,13 @@ SUBROUTINE plugin_ext_forces()
              -at_plumed(1,3)*at_plumed(3,1)*at_plumed(2,2) 
       virial=-sigma*volume
 
+      ! the masses in QE are stored per type, see q-e//Modules/ions_base.f90
+      do ia=1,nat
+        masses_plumed(ia)=amass(ityp(ia))
+      end do
+
       CALL plumed_f_gcmd("setStep"//char(0),istep)
-      CALL plumed_f_gcmd("setMasses"//char(0),amass)
+      CALL plumed_f_gcmd("setMasses"//char(0),masses_plumed)
       CALL plumed_f_gcmd("setForces"//char(0),force)
       CALL plumed_f_gcmd("setPositions"//char(0),tau_plumed)
       CALL plumed_f_gcmd("setBox"//char(0),at_plumed)