Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
plumed mklib
script in v2.10 works as a makefile, so that if a .so is already present it is not recompiled. This is necessary for thread safety. This however causes a problem in the plumed nest where the .so file produced by v2.9 is not regenerated when using master. One possible solution is to encode the version name in the .so file.With this PR, when using
A
.so
file will be generated with namefile.2.10-dev.so
.Notice that the change is apparent only when using
LOAD
, and not when usingplumed mklib
directly. In other words:will still generate a file named
file.so
.I did it in this way, which is completely transparent to users. Indeed, the
.so
file created byLOAD
is a temporary that is never explicitly mentioned by the user. However, it would also be possible to encode the version directly in every use ofplumed mklib
, which I think is what python does when compiling extensions. This would however create problems if someone uses scripts such as:Target release
I would like my code to appear in release v2.10